Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render tooltip in portal #5089

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

tiagoapolo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Ideally tooltips must often be rendered outside their parent to avoid clipping by parent boundaries and that can be easily achieved by rendering in portals using createPortal.

How did you test this code?

Tested by checking every existing tooltip, for tooltips inside of inline modals it did not work properly due to inconsistent z-index management in the app, a future task will be created for creating consistent z-index values when handling hierarchy between modals, tooltips, etc

@tiagoapolo tiagoapolo requested a review from a team as a code owner February 11, 2025 12:39
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 11, 2025 12:39
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:39am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 0:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 11, 2025 0:39am

@tiagoapolo tiagoapolo self-assigned this Feb 11, 2025
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 11, 2025
@tiagoapolo tiagoapolo changed the title Feat/render tooltip in portal feat: render tooltip in portal Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5089 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5089 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5089 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5089 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Uffizzi Preview deployment-60817 was deleted.

@tiagoapolo tiagoapolo merged commit e6d30a4 into main Feb 11, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the feat/render-tooltip-in-portal branch February 11, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants