Skip to content

fix(frontend): gate app boot on ConfigStore.hasLoaded to avoid loader deadlock #7776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talissoncosta wants to merge 2 commits into from
+9 −1
Closed

fix(frontend): gate app boot on ConfigStore.hasLoaded to avoid loader deadlock #7776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e366b83
fix(frontend): gate ConfigProvider initial state on hasLoaded
talissoncosta Jun 12, 2026
fda8da3
fix(frontend): resync ConfigProvider after subscribing to the store
talissoncosta Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion frontend/common/providers/ConfigProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export default (WrappedComponent) => {
super(props)
this.state = {
error: ConfigStore.error,
isLoading: ConfigStore.model ? ConfigStore.isLoading : true,
isLoading: ConfigStore.hasLoaded ? ConfigStore.isLoading : true,
}
ES6Component(this)
}
Expand All @@ -20,6 +20,14 @@ export default (WrappedComponent) => {
isLoading: ConfigStore.isLoading,
})
})
// Re-sync: the store can finish loading before this subscription
// exists, and no further change event arrives to recover.
if (ConfigStore.hasLoaded || ConfigStore.error) {
this.setState({
error: ConfigStore.error,
isLoading: ConfigStore.isLoading,
})
}
}

render() {
Expand Down
Loading