Skip to content

fix(Utils): add guard against null rule value in validateRule #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afsuyadi wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(Utils): add guard against null rule value in validateRule #7779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion frontend/common/utils/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,9 @@
}

if (operatorObj?.value?.toLowerCase?.().includes('semver')) {
if (rule.value == null) {

Check warning on line 810 in frontend/common/utils/utils.tsx

View workflow job for this annotation

GitHub Actions / Lint changed files 

Expected '===' and instead saw '=='
return false
}
return !!semver.valid(`${rule.value.split(':')[0]}`)
}

Expand All @@ -817,7 +820,7 @@
}
case 'REGEX': {
try {
if (!rule.value) {
if (rule.value == null) {

Check warning on line 823 in frontend/common/utils/utils.tsx

View workflow job for this annotation

GitHub Actions / Lint changed files 

Expected '===' and instead saw '=='
throw new Error('')
}
new RegExp(`${rule.value}`)
Expand All @@ -827,6 +830,9 @@
}
}
case 'MODULO': {
if (rule.value == null) {

Check warning on line 833 in frontend/common/utils/utils.tsx

View workflow job for this annotation

GitHub Actions / Lint changed files 

Expected '===' and instead saw '=='
return false
}
const valueSplit = rule.value.split('|')
if (valueSplit.length === 2) {
const [divisor, remainder] = [
Expand Down
Loading