feat(marts): add fact_payments model (Phase 2.2)#7
Merged
Flames4fun merged 1 commit intoFlames4fun:mainfrom Mar 19, 2026
Merged
feat(marts): add fact_payments model (Phase 2.2)#7Flames4fun merged 1 commit intoFlames4fun:mainfrom
Flames4fun merged 1 commit intoFlames4fun:mainfrom
Conversation
Owner
|
Great work!, merging right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closses #6
##Description
Implements
fact_paymentsmart model as specified in Phase 2.2.Changes
dbt/models/marts/facts/fact_payments.sql— built fromstg_paymentswith
order_purchase_datevia LEFT JOIN withint_orders_enricheddbt/models/marts/facts/_fact_payments.yml— documents grain anddefines
not_null,unique, andrelationshipstestsChanges
dbt/models/marts/facts/fact_payments.sql— built fromstg_paymentswith
order_purchase_datevia LEFT JOIN withint_orders_enricheddbt/models/marts/facts/_fact_payments.yml— documents grain anddefines
not_null,unique, andrelationshipstestsGrain
1 row per
payment_key(surrogate key oforder_id + payment_sequential)Join path & tradeoff
order_purchase_dateis sourced fromint_orders_enrichedvia LEFT JOINon
order_id.int_orders_enrichedwas chosen overfact_ordersto avoida mart-to-mart dependency, which is an anti-pattern in dbt layering.
LEFT JOIN ensures no payments are lost if an
order_idhas no match.Verification