Skip to content

Fix hidden SMAPI console on macOS #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Floogen merged 7 commits into from
Jan 29, 2026
Merged

Fix hidden SMAPI console on macOS #309

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d01911
Potential fix for hidden SMAPI console on macOS
Floogen Jan 28, 2026
cbfcd1b
Adjusted to execute StardewModdingAPI directly for macOS
Floogen Jan 28, 2026
f20b18b
Quick test of use-current-shell argument
Floogen Jan 28, 2026
7ffb4fa
Fixed reverted UseShellExecute usage
Floogen Jan 28, 2026
82545c4
Testing /usr/bin/open
Floogen Jan 28, 2026
efa76bd
Testing zsh usage
Floogen Jan 28, 2026
871c871
Swapped to open command for Terminal usage
Floogen Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions Stardrop/Utilities/External/SMAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,29 +23,57 @@ static class SMAPI

public static ProcessStartInfo GetPrepareProcess(bool hideConsole)
{
var arguments = String.Empty;
var smapiInfo = new FileInfo(Pathing.GetSmapiPath());

var fileName = smapiInfo.FullName;
var arguments = string.Empty;
var parsedModPath = string.Empty;
if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux) is true)
{
fileName = "/usr/bin/env";
arguments = $"bash -c \"SMAPI_MODS_PATH='{Pathing.GetSelectedModsFolderPath()}' '{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewValley")}'\"";
parsedModPath = $"'{Pathing.GetSelectedModsFolderPath()}'";
}
else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX) is true)
{
arguments = $"bash -c \"'{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewModdingAPI")}' --mods-path '{Pathing.GetSelectedModsFolderPath()}'\"";
fileName = "/usr/bin/open";
arguments = $"-a \"Terminal\" \"{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewModdingAPI")}\" --args --mods-path \"{Pathing.GetSelectedModsFolderPath()}\"";

//Skip setting parsedModPath for macOS due to --mods-path usage
//parsedModPath = $"\"{Pathing.GetSelectedModsFolderPath()}\"";

/* Alternative route (using AppleScript) of activating Terminal + SMAPI
fileName = "/usr/bin/env";
arguments = $@"osascript -e ""tell application \""Terminal\""
set smapi_path to \""{Pathing.GetSmapiPath().Replace("StardewModdingAPI.dll", "StardewModdingAPI")}\""
set mods_path to \""{Pathing.GetSelectedModsFolderPath()}\""
activate
do script \""\"" & quoted form of the POSIX path of smapi_path & \"" --mods-path \"" & quoted form of the POSIX path of mods_path
end tell""";
*/
}
else
{
parsedModPath = Pathing.GetSelectedModsFolderPath();
}

Program.helper.Log($"Starting SMAPI with the following arguments: {arguments}");
var processInfo = new ProcessStartInfo
{
FileName = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? smapiInfo.FullName : "/usr/bin/env",
FileName = fileName,
Arguments = arguments,
WorkingDirectory = smapiInfo.DirectoryName,
RedirectStandardOutput = false,
RedirectStandardError = false,
CreateNoWindow = hideConsole,
UseShellExecute = false
};
processInfo.EnvironmentVariables["SMAPI_MODS_PATH"] = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) is false ? $"'{Pathing.GetSelectedModsFolderPath()}'" : Pathing.GetSelectedModsFolderPath();

// Set SMAPI_MODS_PATH EnvironmentVariable if required
if (string.IsNullOrEmpty(parsedModPath) is false)
{
processInfo.EnvironmentVariables["SMAPI_MODS_PATH"] = parsedModPath;
}

return processInfo;
}
Expand Down
Loading