Fix arm64 compilation errors #10
Conversation
Signed-off-by: red <[email protected]>
|
@FlorentRevest @matttbe @zouyonghao @PacheNico I could not assign this PR to you guys, please take a look when you get a chance |
Remove invalid `qemu` package, tested on Ubuntu 24.04
| @@ -97,6 +98,7 @@ elif [ "${TARGET_ARCH}" = "arm64" ]; then | |||
| : ${PROOT_ARGS:="-q qemu-aarch64-static"} | |||
| : ${SYZKALLER_TARGETARCH:="arm4"} | |||
| : ${ROOT_MNT:="/dev/vda"} | |||
| : ${CROSS_COMPILE:="aarch64-linux-gnu-"} | |||
There was a problem hiding this comment.
Mh I'm surprised this is necessary. When using LLVM=1, I don't need to every provide a CROSS_COMPILE flag. I intentionally left that one out originally because I didn't want to have to pick a target triplet here. My experience is that there are bazillions of variants of "arm64 linux" toolchain triplet and they are wrong more often than not. Are you maybe using downstream changes to use GCC ? GCC needs that but not LLVM in my experience.
Or do you have further evidences that this is an issue ? Eg: reproducing steps etc.
| @@ -65,7 +65,10 @@ curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microso | |||
| sudo install -o root -g root -m 644 microsoft.gpg /usr/share/keyrings/microsoft-archive-keyring.gpg | |||
| sudo sh -c 'echo "deb [arch=amd64,arm64,armhf signed-by=/usr/share/keyrings/microsoft-archive-keyring.gpg] https://packages.microsoft.com/repos/vscode stable main" > /etc/apt/sources.list.d/vscode.list' | |||
| sudo apt update | |||
| sudo apt install code gdb-multiarch ccache clang clangd llvm lld libguestfs-tools libssl-dev trace-cmd python3-pip jsonnet libelf-dev bison bindfs mmdebstrap proot systemtap flex yacc bc debian-archive-keyring | |||
| sudo apt install code gdb-multiarch ccache clang clangd llvm lld libguestfs-tools libssl-dev trace-cmd python3-pip jsonnet libelf-dev bison bindfs mmdebstrap proot systemtap flex yacc bc debian-archive-keyring qemu-system-arm crossbuild-essential-arm64 qemu-user-static binfmt-support | |||
There was a problem hiding this comment.
The QEMU changes here look legit but that crossbuild-essential-arm64 seems fishy. This pulls in GCC and g++. This setup intentionally sticks to LLVM because it has further implications like the clangd VSCode extension working properly to provide LSP etc... It looks like you end up on a frankenstein GCC/LLVM setup which will be half broken.
There was a problem hiding this comment.
Makes sense, I already had several versions (and flavors) of GCC on my machine, I was not aware that LLVM was building the kernel. I will close this PR. since it seems like I have a frankenbuild.
There was a problem hiding this comment.
Only the CROSS_COMPILE bits in tasks.sh and the crossbuild-essential-arm64 package here seem unrelated but installing qemu-system-arm qemu-user-static binfmt-support qemu-user-binfmt would still make sense, feel free to re-open a PR for that if you'd like to contribute those bits.
| sudo apt install code gdb-multiarch ccache clang clangd llvm lld libguestfs-tools libssl-dev trace-cmd python3-pip jsonnet libelf-dev bison bindfs mmdebstrap proot systemtap flex yacc bc debian-archive-keyring | ||
| sudo apt install code gdb-multiarch ccache clang clangd llvm lld libguestfs-tools libssl-dev trace-cmd python3-pip jsonnet libelf-dev bison bindfs mmdebstrap proot systemtap flex yacc bc debian-archive-keyring qemu-system-arm crossbuild-essential-arm64 qemu-user-static binfmt-support | ||
| for fmt in aarch64 alpha arm armeb cris hexagon hppa loongarch64 m68k microblaze mips mipsel mipsn32 mipsn32el mips64 mips64el ppc ppc64 ppc64le riscv32 riscv64 s390x sh4 sh4eb sparc sparc32plus sparc64 xtensa xtensaeb; do | ||
| sudo update-binfmts --import qemu-$fmt; |
There was a problem hiding this comment.
It looks like this loop should be replaced by installing the qemu-user-binfmt package
The README.md file does not include the quemu packages required for arm64 platforms, this causes issues with the
create-rootfssub command intask.shThis pull request updates the packages required on README.md and adds the missing
CROSS_COMPILERmacro to prevent errors when trying to create the rootfs for arm64 platforms.Additionally the package list now includes the toolchain required to build arm64 platforms.