fix: split CompletionParams and CompletionContext computation#1
Open
rubenporras wants to merge 2 commits into
Open
fix: split CompletionParams and CompletionContext computation#1rubenporras wants to merge 2 commits into
rubenporras wants to merge 2 commits into
Conversation
to reduce the time until we extract the character at the document offset
Author
|
@FlorianKroiss , if you agree, you can accept this on your fork and I think it will then be applied to your PR, then we can merge both together. |
| } | ||
|
|
||
| private @Nullable String getPositionCharacter(IDocument document, int offset) { | ||
| int positionCharacterOffset = offset > 0 ? offset - 1 : offset; |
Owner
There was a problem hiding this comment.
This is missing a check if the document is empty. That's probably why a lot of tests are failing.
@rubenporras I now have a better idea of what you want to change. If it is ok for you, I would apply these change manually to my fork and incorporate the missing check?
Author
There was a problem hiding this comment.
I thought the check was not necessay, but I cannot argue with the failing tests ;)
FlorianKroiss
force-pushed
the
abort-on-badlocation
branch
2 times, most recently
from
c30715b to
9d391c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to reduce the time until we extract the character at the document offset