Fix behavior of volume envelope delay phase #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrbumpy409 @mawe42 FYI |
|
derselbst
added a commit
that referenced
this pull request
Sep 17, 2024
derselbst
added a commit
that referenced
this pull request
Sep 19, 2024
derselbst
added a commit
that referenced
this pull request
Jan 25, 2025
derselbst
added a commit
that referenced
this pull request
Jan 25, 2025
derselbst
added a commit
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, fluidsynth used an optimization that allowed silent voices to be completely skipped rendering. While this behavior might make sense from a performance point of view, it does break the expected behavior of the delay phase demanded by the SF2, see #1312 for details. Essentially, the delay phase shall not postpone the sample, rather the sample should be played "silently". And that's what this PR does. However, as the rendered samples will always become zero, the nearest neighbor interpolation is used as a minor optimization in this case.
Fixes #1312.