Add support for showing code actions #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
matthew-carroll
approved these changes
Dec 14, 2024
Contributor
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM - there's a lot going on in this PR. We can iterate as issues arise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for showing code actions.
This PR adds initial support for code actions. At the moment, only for showing them, not applying.
I also made some adjustments to the hover popover, because it wasn't working after we switched the way we display the code.
The
PopoverListused to display the actions popover was extracted and adapted fromSuperEditor.I also made some adjustments in the way we start LSP tests, to wait until the LSP notifies us it finished analyzing the project. Without this, some methods, like the code actions, just return an empty array.
It seems the code actions return some different options on Flutter master x stable. We should decide whether we want to target the stable or master branch.
It seems that, even with the latest changes, the file rename test isn't working on the CI, I'm letting this commented out for now.
Screen.Recording.2024-12-13.at.11.37.26.mov