Skip to content

Conversation

@rutvik110
Copy link
Contributor

[Feat] File rename support

Adds support to send file rename notifications to LSP.

@rutvik110 rutvik110 self-assigned this Dec 18, 2024
Comment on lines 349 to 351
onTap: () {
_renameFile(context);
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the rename be invoked by pressing ENTER on a file selected in the file tree instead of this button?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. I'll update it.

@rutvik110
Copy link
Contributor Author

rutvik110 commented Dec 19, 2024

@angelosilvestre Made the requested updates and updated the rename file flow to launch rename file dialog when pressed enter on a file in the tree view.

@rutvik110
Copy link
Contributor Author

@angelosilvestre Just pinging you again in case you missed this.

Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rutvik110 rutvik110 merged commit 2d9a947 into main Dec 27, 2024
1 check passed
@rutvik110 rutvik110 deleted the feat_file_rename_support branch December 27, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants