Store unique + randomly shuffled animal names #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstjean
approved these changes
Jan 5, 2025
test/utils.jl
Outdated
| @test length(MacroTools.animals) == 214 | ||
| @test allunique(MacroTools.animals) | ||
| @test all(islowercase ∘ first ∘ string, MacroTools.animals) | ||
| @test MacroTools.animals == Random.shuffle!(StableRNGs.StableRNG(1234), sort(MacroTools.animals)) |
There was a problem hiding this comment.
Is that the only reason for the test Random dependency? If so I would just take it out, along with StableRNG. I don't see why anyone would care about this particular test, and the less code the better...
There was a problem hiding this comment.
Yes, it is. The test is definitely not necessary, I included it only to demonstrate how the list was generated. I'll remove it together with the test dependencies.
|
Thanks! |
|
Maybe it's time for a new release? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the animal names in
animals.txtare not unique ("Donkey" appears twice) and they are only converted to lowercase characters and shuffled when loaded. In particular, the random shuffling requires MacroTools to depend on Random which is not used anywhere else in the package.This PR removes the duplicate entry and preshuffles the animal names (for reproducibility I used
StableRNG(1234)). I also added tests.PR Checklist