feat(indexer): default contract_events ingested_at at the database#551
Merged
Jagadeeshftw merged 3 commits intoJun 29, 2026
Conversation
|
@Olasunkanmi975 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Hi maintainer, please review my work for approval |
Contributor
Author
|
@Jagadeeshftw hi maintainer please review my pr and merge |
Contributor
|
solid change - moving ingested_at to a database default means the timestamp is always server-authoritative and can never be omitted or spoofed by application code. the migration sets DEFAULT now() at the db level, and the insert path no longer needs to supply the value. also prevents a class of bugs where a caller forgets the field and events end up with null timestamps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##closed #509
Summary
Moves
contract_events.ingested_atto a server-authoritative database default, ensuring all ingested events receive a consistent timestamp even when application code omits the value.Changes
contract_events.ingested_atwithDEFAULT now().Testing
Covered:
ingested_at.ingested_at(if supported).ingested_atremains non-null.Validation
npm testSecurity
Using database-generated ingest timestamps prevents missing timestamps and reduces reliance on callers for authoritative ingest time.