feat: add reason-specific microcopy to ZeroAccrualBanner - #1355
Open
waterWang wants to merge 1 commit into
Open
Conversation
… / paused / pre-cliff) Adds three new reason variants to ZeroAccrualBanner: - "not-started": streams haven't started yet - "paused": sender has paused the stream (already existed) - "pre-cliff": cliff period hasn't been reached Updates the Streams page and Recipient page to use "pre-cliff" instead of the older "cliff" reason. Closes Fluxora-Org#1284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds reason-specific microcopy to
ZeroAccrualBannerso recipients see distinct explanatory text depending on *why* their balance is zero.Changes
New reason variants
not-started— streams are configured but haven't started yetpre-cliff— streams are live but the cliff date hasn't been reachedpaused— already existed, kept as-isUpdated callers
pre-cliffinstead ofcliffwhen no zero-rate stream is detectedpre-cliffinstead ofcliffBackward compatibility
All existing reason values (
cliff,paused,rate-zero,schedule-future) remain supported.Testing
not-startedtitle/description,pre-clifftitle/description,not-startedchip label,pre-cliffchip label)Closes #1284