refactor: extract duplicated inline SVG icons into shared icons module (Closes #1270) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #1364
Open
waterWang wants to merge 1 commit into
Conversation
Closes Fluxora-Org#1270) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - Create src/components/icons/CloseIcon.tsx with configurable size prop - Create src/components/icons/ChevronIcon.tsx with configurable size prop - Create src/components/icons/index.ts barrel export - Replace inline close (X) SVG in ConnectWalletModal.tsx with <CloseIcon /> - Replace inline chevron SVG in ConnectWalletModal.tsx with <ChevronIcon /> - Fix pre-existing bug: define and export LOADING_TEST_IDS from Skeleton.tsx - Fix pre-existing bug: add missing LOADING_TEST_IDS import to StreamsLoading.tsx, RecipientLoading.tsx, TreasuryOverviewLoading.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/components/ConnectWalletModal.tsxhand-rolls its own inline<svg>markup for close (X) and chevron icons. This PR extracts these into a sharedsrc/components/icons/module so they can be reused anywhere in the codebase with consistent sizing and styling.Changes
src/components/icons/CloseIcon.tsx— Extracted close (X) icon withsizeandclassNamepropssrc/components/icons/ChevronIcon.tsx— Extracted right-pointing chevron icon withsizeandclassNamepropssrc/components/icons/index.ts— Barrel export for both iconsConnectWalletModal.tsx— Replaced inline SVGs with<CloseIcon />and<ChevronIcon />Skeleton.tsx— Defined and exportedLOADING_TEST_IDSconstant (pre-existing bug fix)StreamsLoading.tsx,RecipientLoading.tsx,TreasuryOverviewLoading.tsx— Added missingLOADING_TEST_IDSimport (pre-existing bug fix)Testing
Closes #1270