fix: add live cost breakdown to step-3 review summary (Closes #1276) - #1367
Open
waterWang wants to merge 1 commit into
Open
fix: add live cost breakdown to step-3 review summary (Closes #1276)#1367waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Add a cost-breakdown section to the CreateStreamModal step-3 review that shows the required deposit (rate × duration) vs the user's deposit, derived from live form state on every render (not memoized against a stale snapshot). Also fix the review test file which was missing required mocks (Walletcontext, ToastProvider, i18n, useModalAccessibility). Closes Fluxora-Org#1276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Step-3 review summary now shows live cost breakdown
Problem
When a user reaches step 3, clicks Back to step 2, changes the accrual rate or duration, then advances to step 3 again, the review summary's deposit/cost figures could display stale values — the required deposit (rate × duration) was not visible on the review step at all.
Changes
Screenshots
Before: Step 3 review showed only the deposit amount card, with no visibility into the calculated required deposit.
After: Step 3 review now includes a cost breakdown section showing the required deposit calculation alongside the user's deposit.
Testing