feat: add sticky condensed hero header to StreamDetail page [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #1368
Open
waterWang wants to merge 2 commits into
Open
Conversation
Add a cost-breakdown section to the CreateStreamModal step-3 review that shows the required deposit (rate × duration) vs the user's deposit, derived from live form state on every render (not memoized against a stale snapshot). Also fix the review test file which was missing required mocks (Walletcontext, ToastProvider, i18n, useModalAccessibility). Closes Fluxora-Org#1276
Add a sticky hero bar that appears when the user scrolls past the full hero section on the StreamDetail page. The condensed version shows stream name, health status pill, and status label. - IntersectionObserver watches the full hero element's top edge - When hero scrolls out of view, a sticky bar with condensed info appears at the top of the viewport - Smooth opacity transition for appearance/disappearance - Sticky bar does not overlap the app navbar (position: sticky, top: 0) - All existing tests continue to pass Closes Fluxora-Org#1279 [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
Author
|
Wallet address for bounty payout: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1279
Adds a sticky condensed hero bar that appears at the top of the viewport when the user scrolls past the full hero section on the StreamDetail page. The condensed version shows the stream name, health status pill, and status label, keeping key context visible while scrolling through the timeline and sidebars.
Changes
isHeroStickyis set totrue.position: sticky; top: 0so it stays below the app navbar. Contains a back-to-streams link, stream name (truncated with ellipsis), health status pill, and status label.role="complementary"andaria-label="Stream summary". Health pill hasaria-labelfor screen readers.Testing
All 10 existing StreamDetail tests pass:
Wallet
fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT(Solana)