feat: add live character counter to InputField maxLength fields (Closes #1291) - #1373
Open
waterWang wants to merge 1 commit into
Open
feat: add live character counter to InputField maxLength fields (Closes #1291)#1373waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in live character counter (
42/100style) toInputFieldfields that declare amaxLengthprop, implementing issue #1291.Changes
src/components/InputField.tsxmaxLengthprop toInputFieldProps— counter only renders when explicitly provided<input>'s currentvalueto derivecharCountin real timearia-describedbyon the inputaria-live="polite"announcement (600ms, via a visually-hidden.input-char-counter__announcer) so screen readers aren't overwhelmed on every keystrokemaxLengthto the underlying<input>element for native browser enforcementsrc/components/CreateStreamModal.css.input-char-counter,.input-char-counter__text,.input-char-counter--warning, and.input-char-counter__announcerstylessrc/components/__tests__/InputField.characterCounter.test.tsxmaxLength, counter display, live update while typing,aria-describedbylinkage, warning threshold, debounced announcement, andmaxlengthattribute forwardingTesting
inputvariable, and the debounced validation test has a timer interaction issue)aria-describedby, debouncedaria-live="polite", warning not color-only — also bolds the text)