refactor(stellar): make confirmation polling budget configurable (#359)

[webthreejunkie-sudo]

Summary

Fixes #359. waitForTransaction in src/lib/stellar/tx.ts previously hardcoded maxRetries = 15 and delayMs = 1500, causing false timeout failures on slow Testnet. Both values are now driven by transactionConfig so they can be tuned per environment without code edits.

Changes

src/lib/transactionConfig.ts

• Added readFiniteNumber helper — unlike readPositiveNumber, it parses any finite number (including negative/zero) so downstream clamping works correctly.
• Added confirmationMaxRetries (default 15, clamped [1, 300], env VITE_TX_CONFIRMATION_MAX_RETRIES).
• Added confirmationDelayMs (default 1500 ms, clamped [100, 30000], env VITE_TX_CONFIRMATION_DELAY_MS).
• Both fields carry TSDoc with the max-wait formula: confirmationMaxRetries × confirmationDelayMs.

src/lib/stellar/tx.ts

• waitForTransaction signature defaults replaced: 15 → transactionConfig.confirmationMaxRetries ?? 15, 1500 → transactionConfig.confirmationDelayMs ?? 1500.
• Fully backward-compatible — callers that pass explicit arguments are unaffected.

src/vite-env.d.ts

• Declared VITE_TX_CONFIRMATION_MAX_RETRIES and VITE_TX_CONFIRMATION_DELAY_MS as optional string env vars.

.env.example / docs/environment.md

• Full documentation for both new vars: purpose, clamping range, format, default, max-wait formula.

Tests

• transactionConfig.test.ts: 20 new cases covering valid reads, decimal floor, clamp-to-min (0 and negative), clamp-to-max, boundary values, and non-numeric fallback for both new fields.
• tx.test.ts: 4 new cases in waitForTransaction — configurable confirmation budget: custom retries, custom delay timing, early success within budget, default 15-retry behaviour.

Test Files  2 passed (2)
     Tests  53 passed (53)

Security

• Values outside the allowed range are clamped, never silently ignored, preventing misconfiguration from creating an unbounded or zero-wait loop.
• No secrets involved; all vars are client-side timing controls only.
  closes Make waitForTransaction maxRetries and delay configurable via transactionConfig #359

[drips-wave]

@webthreejunkie-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits