Fix/reject self send stream#504
Merged
Jagadeeshftw merged 2 commits intoJun 29, 2026
Merged
Conversation
|
@blurbeast Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
blurbeast
force-pushed
the
fix/reject-self-send-stream
branch
from
3169bbd to
b939aa0
Compare
4 tasks
Contributor
|
rejecting self-send streams at the validation layer is the right place to catch this -- letting it through to the contract would produce a confusing error that's hard to surface meaningfully to the user. the early validation with a clear message is much better UX. clean rebase on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr resolves the issue tagged below ...
closes #353