docs: add CONTRIBUTING.md and link from README#506
Merged
Jagadeeshftw merged 2 commits intoJun 29, 2026
Merged
Conversation
## What was done
Added a new CONTRIBUTING.md file at the repo root and updated README.md
to link to it at the top of the Contributing / CI section.
## Why
The repo had many design .md specs and a detailed README but no single
source of truth for new contributors. Without a contributing guide,
onboarding required reading scattered files to understand setup, branch
naming, commit format, and what CI checks must pass. This closes the gap.
## How it was implemented
### CONTRIBUTING.md
Written from scratch and tailored specifically to this React + Vite +
TypeScript + Vitest + Playwright stack. Sections covered:
1. **Prerequisites** — Node 18+, npm/pnpm, Git, Playwright browsers.
2. **Local setup** — exact commands: clone,
pm install,
cp .env.example .env,
pm run dev. App URL noted.
3. **Environment variables** — table of every VITE_* variable with
required-at-runtime status and purpose, cross-linked to
docs/environment.md for full detail. Security note prominently placed.
4. **Branch naming** — <type>/<short-kebab-description> pattern with a
table of allowed types matching the commit convention types, plus
concrete examples.
5. **Commit conventions** — Conventional Commits format documented with
the summary-line length rule, imperative mood requirement, issue footer
(Closes #<n>) pattern, and three real-world examples drawn from this
project's domain.
6. **Development workflow** — dev, �uild, preview, �uild:report
commands.
7. **Testing** — three sub-sections:
- Unit tests:
pm run test (single run) and
pm run test:watch.
- Coverage:
pm run test:coverage with the 95% threshold requirement
and instruction to expand �itest.config.ts include list for new
production modules.
- E2E:
px playwright install --with-deps once, then
pm run test:e2e /
pm run test:a11y. Playwright auto-server
behaviour explained.
8. **Lint and format** — all four npm scripts with a note that CI fails on
lint errors.
9. **Design specs and docs** — skimmable table linking the major spec files
at the repo root plus docs/ references.
10. **PR expectations** — checklist mirroring the PR template plus the
rule to link issues and keep PRs focused.
11. **Security notes** — explicit warning that VITE_* vars are public and
baked into the client bundle; private secrets belong on the backend;
address sanitisation and RequireWallet guard caveats.
### README.md
Added a one-line forward-link to CONTRIBUTING.md at the top of the
existing Contributing / CI section so existing readers are directed to the
new file immediately.
## Files changed
- CONTRIBUTING.md — created (new file)
- README.md — one-line addition linking to CONTRIBUTING.md
## Verification
All documented commands were verified against package.json scripts,
�itest.config.ts, playwright.config.ts, and .env.example to ensure
accuracy. No source code was modified.
Closes Fluxora-Org#390
|
@olawaleakanbi035-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
a CONTRIBUTING.md has been overdue for a while -- having the dev setup steps, branch naming conventions, and PR checklist in one place will save first-time contributors a lot of back-and-forth. linking it from the README is a nice touch so it's easy to find. thanks for putting this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Added a new CONTRIBUTING.md file at the repo root and updated README.md to link to it at the top of the Contributing / CI section.
Why
The repo had many design .md specs and a detailed README but no single source of truth for new contributors. Without a contributing guide, onboarding required reading scattered files to understand setup, branch naming, commit format, and what CI checks must pass. This closes the gap.
How it was implemented
CONTRIBUTING.md
Written from scratch and tailored specifically to this React + Vite + TypeScript + Vitest + Playwright stack. Sections covered:
cp .env.example .env, pm run dev. App URL noted.
pm run test:watch.
and instruction to expand �itest.config.ts include list for new
production modules.
pm run test:e2e /
pm run test:a11y. Playwright auto-server
behaviour explained.
8. Lint and format — all four npm scripts with a note that CI fails on lint errors.
9. Design specs and docs — skimmable table linking the major spec files at the repo root plus docs/ references.
10. PR expectations — checklist mirroring the PR template plus the rule to link issues and keep PRs focused.
11. Security notes — explicit warning that VITE_* vars are public and baked into the client bundle; private secrets belong on the backend; address sanitisation and RequireWallet guard caveats.
README.md
Added a one-line forward-link to CONTRIBUTING.md at the top of the existing Contributing / CI section so existing readers are directed to the new file immediately.
Files changed
Verification
All documented commands were verified against package.json scripts, �itest.config.ts, playwright.config.ts, and .env.example to ensure accuracy. No source code was modified.
Closes #390
Summary
Changes
Test plan
npm run buildpasses (type-check + production build)npm run testpasses (all unit tests green)npm run test:coveragepasses (statements/branches/functions/lines ≥ 95%)vitest.config.tsis expanded if new production modules are addedCoverage gate
CI enforces 95% coverage thresholds (statements, branches, functions, lines) via
the
coveragejob in.github/workflows/ci.yml. The job runsnpm run test:coverageand fails the PR check when any threshold is missed. The coverage report is uploaded
as a build artifact for every run.
To add a new production file to the coverage baseline, append it to the
includearray in
vitest.config.tsand ensure tests cover it before opening the PR.