Fix KeyError and recursion issue in control_dataset.py when loading cached text embeddings#56
Open
tori29umai0123 wants to merge 1 commit intoFlyMyAI:mainfrom
Open
Fix KeyError and recursion issue in control_dataset.py when loading cached text embeddings#56tori29umai0123 wants to merge 1 commit intoFlyMyAI:mainfrom
tori29umai0123 wants to merge 1 commit intoFlyMyAI:mainfrom
Conversation
Fix KeyError and recursion issue in control_dataset.py when loading cached text embeddings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KeyError and recursion issue in control_dataset.py when loading cached text embeddings
This pull request fixes a bug that caused a KeyError('.txt') and subsequent infinite recursion in control_dataset.py when a missing text embedding was encountered.
Changes:
Added a safe check for missing keys in cached_text_embeddings
Prevented infinite recursion in getitem by handling missing samples gracefully
Improved logging for debugging missing .txt entries
Impact:
This change stabilizes data loading during training and prevents crashes due to invalid or missing text files.
No modification to train_qwen_edit_lora.py is required.