Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intermediate private package does not expose content #79

Merged
merged 1 commit into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"node": true
},
"rules": {
"arrow-parens": "off",
"object-curly-newline": 0,
"arrow-body-style": 0,
"implicit-arrow-linebreak": 0,
Expand Down
2 changes: 1 addition & 1 deletion src/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module.exports = class Metadata {
findNamesInStepsPaths(stepsPaths) {
return this._data
.filter(({ type }) => type !== 'step')
.filter(({ path }) => stepsPaths.includes(path))
.filter(({ path }) => stepsPaths.some(stepPath => path.startsWith(stepPath)))
.map(({ name }) => name);
}
};
53 changes: 40 additions & 13 deletions test/integration/plan.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,32 +189,32 @@ describe('Plan', () => {
expect.assertions(2);
const value = Symbol('value');
const plan = (rootPlan) => rootPlan
.addValue('key', value)
.addAlias('alias', 'key');
.addValue('key', value)
.addAlias('alias', 'key');

const { key, alias } = execute(plan);
expect(key).toBe(value);
expect(alias).toBe(value);
});

it('add a public alias from private key', () => {
expect.assertions(2);
const value = Symbol('value');
const plan = (rootPlan) => rootPlan
.addValue('key', value, { private: true })
.addAlias('alias', 'key', { private: false});

const { key, alias } = execute(plan);
expect(key).toBeUndefined();
expect(alias).toBe(value);
expect.assertions(2);
const value = Symbol('value');
const plan = (rootPlan) => rootPlan
.addValue('key', value, { private: true })
.addAlias('alias', 'key', { private: false });

const { key, alias } = execute(plan);
expect(key).toBeUndefined();
expect(alias).toBe(value);
});

it('add a private alias from public key', () => {
expect.assertions(2);
const value = Symbol('value');
const plan = (rootPlan) => rootPlan
.addValue('key', value)
.addAlias('alias', 'key', { private: true});
.addValue('key', value)
.addAlias('alias', 'key', { private: true });

const { key, alias } = execute(plan);
expect(key).toBe(value);
Expand Down Expand Up @@ -856,6 +856,33 @@ describe('Plan', () => {
.with('key', jest.fn()))))
.toThrow('Using with on path "p2/key": Key does not exists: key');
});

it('p1/p2/private-p3/p4/key is not exposed to outside', () => {
expect(execute(newPlan()
.addPackage('p1', (p1) => p1
.addPackage('p2', p2 => p2
.addPackage('p3', p3 => p3
.addPackage('p4', p4 => p4
.addValue('key', 'value')), { private: true })))).key).toBeUndefined();
});

it('private-p1/p2/p3/p4/key is exposed to outside', () => {
expect(execute(newPlan()
.addPackage('p1', (p1) => p1
.addPackage('p2', p2 => p2
.addPackage('p3', p3 => p3
.addPackage('p4', p4 => p4
.addValue('key', 'value')))), { private: true })).key).toBe('value');
});

it('p1/p2/p3/p4/private-key is not exposed to outside', () => {
expect(execute(newPlan()
.addPackage('p1', (p1) => p1
.addPackage('p2', p2 => p2
.addPackage('p3', p3 => p3
.addPackage('p4', p4 => p4
.addValue('key', 'value', { private: true })))))).key).toBeUndefined();
});
});

describe('replace', () => {
Expand Down
Loading