Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing delay prop to AnimatePropTypeInterface #2658

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

JasonPan
Copy link
Contributor

@JasonPan JasonPan commented Oct 3, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: d382ae7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 1:33am

@carbonrobot
Copy link
Contributor

Thanks for the PR!

delay is currently part of the VictoryAnimationProps interface. Do you have an example that can help guide the review here to understand why we want to add it to AnimatePropTypeInterface?

@carbonrobot carbonrobot merged commit fba0f47 into FormidableLabs:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants