Skip to content

Conversation

@NaeemBolchhi
Copy link

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Screenshots

  • Asset:
  • Colemak:
  • Colemak-DH:
  • Niro:
  • Soul:
  • Workman:

Acknowledgement

@Aga-C
Copy link
Member

Aga-C commented Aug 18, 2024

Thanks for contributing, but next time please create an issue or discussion first (as stated in the contribution guidelines).

@NaeemBolchhi
Copy link
Author

NaeemBolchhi commented Aug 18, 2024

Apologies about not creating an issue first. It wasn't clear to me that I needed to do it (maybe make it a bit clearer?). It says to make sure that the new feature or bug is already reported and is open to pull requests, but does not mention that I should open an issue myself if one does not already exist. I'm not a native English speaker, so I apologize again if this was obvious and I misunderstood. Should I open an issue now?

@Aga-C
Copy link
Member

Aga-C commented Aug 18, 2024

No need to open a new issue, just remember for the future 🙂

@naveensingh
Copy link
Member

naveensingh commented Oct 25, 2024

Does anyone use these layouts? To anyone reading this, please comment if you do or if you would like to.

@Orange-Murker
Copy link

Does anyone use these layouts? To anyone reading this, please comment if you do or if you would like to.

I use Colemak and will be using my own build of Fossify Keyboard for it until this PR gets merged

@naveensingh
Copy link
Member

Thank you, I will consider merging it.

@TheIronMarx
Copy link

Still hoping Colemak layout can be merged up. I'd switch today if it were available.

@naveensingh
Copy link
Member

@NaeemBolchhi If you are still here, could you please resolve the conflicts?

@naveensingh
Copy link
Member

The build is failing now due to missing imports (wildcards are not used anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants