Enable all tests that were previously failing due to #3206 #3689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
changed the title
alecgrieser
approved these changes
Oct 23, 2025
alecgrieser
approved these changes
Oct 23, 2025
| - explain: "AISCAN(MV1 <,> BY_GROUP -> [_0: VALUE:[0]]) | MAP (_ AS _0) | ON EMPTY NULL | MAP (coalesce_long(_._0._0, promote(0l AS LONG)) AS _0)" | ||
| # https://github.com/FoundationDB/fdb-record-layer/issues/3206 is fixed since 4.8.1.0 | ||
| - maxRows: 1 | ||
| - initialVersionAtLeast: 4.8.1.0 |
Collaborator
There was a problem hiding this comment.
This LGTM, but I believe that this change will result in mixed mode failures when run with versions prior to 4.8.1.0. Which should be okay at some point, but we may want to hold off until we no longer care about checking for compatibility with versions older than that, which may mean another two weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.