Make Lucene partitioner thread-safe #3699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the concurrentUpdate to run with a single partition, and adds usages of AsyncLock to ensure that updates to the partition metadata work correctly. Before calling the issue complete an additional test should be added that does concurrent inserts, and one for concurrent deletes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene partitioner is not thread safe when records are updated concurrently.
The partition
countand boundaries are not thread safe and can skew in multi threaded updates.The changes include protecting the partition metadata changes with a
keyspacelock.The
LuceneIndexMaintenanceTest.concurrent*tests have been extended to run in partitioned setup and are now passing.In addition, a bug where empty partitions were not removed was uncovered, and a fix was introduced, with accompanying tests. Empty partitions (first, middle and last) are removed with their index data, ensuring at least one partition is always left behind.
Resolves #2990