vector index maintainer #3738
Merged
vector index maintainer #3738
+4,313
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normen662
force-pushed
the
vector-index-maintainence
branch
from
71cc760 to
7f1d54e
Compare
normen662
force-pushed
the
vector-index-maintainence
branch
6 times, most recently
from
bdcc506 to
aa1d6d4
Compare
normen662
force-pushed
the
vector-index-maintainence
branch
from
aa1d6d4 to
15e7df6
Compare
Merge remote-tracking branch 'upstream/main' into vector-index-maintainence
alecgrieser
requested changes
Nov 19, 2025
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/CompactStorageAdapter.java
Show resolved
Hide resolved
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/HNSW.java
Show resolved
Hide resolved
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/HNSW.java
Show resolved
Hide resolved
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/Config.java
Outdated
Show resolved
Hide resolved
fdb-extensions/src/main/java/com/apple/foundationdb/linear/RealVector.java
Outdated
Show resolved
Hide resolved
...st/java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexTestBase.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexTest.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexTest.java
Show resolved
Hide resolved
...st/java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexTestBase.java
Outdated
Show resolved
Hide resolved
...st/java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexTestBase.java
Outdated
Show resolved
Hide resolved
Merge remote-tracking branch 'upstream/main' into vector-index-maintainence
alecgrieser
requested changes
Nov 25, 2025
Collaborator
alecgrieser
left a comment
alecgrieser
left a comment
There was a problem hiding this comment.
Great, overall, looks good!
A few small things. One is that I think the handling of snapshot isolation level is still not quite in the index scan method, as it should figure that out from the ExecuteProperties rather than being hard-coded. The other is a request for an additional test of HNSW_RETURN_VECTORS, though it's maybe overkill
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/Config.java
Show resolved
Hide resolved
fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/Config.java
Show resolved
Hide resolved
.../java/com/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexMaintainer.java
Outdated
Show resolved
Hide resolved
...om/apple/foundationdb/record/provider/foundationdb/indexes/VectorIndexMaintainerFactory.java
Show resolved
Hide resolved
...java/com/apple/foundationdb/record/provider/foundationdb/VectorIndexScanComparisonsTest.java
Show resolved
Hide resolved
Merge remote-tracking branch 'upstream/main' into vector-index-maintainence
alecgrieser
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.