-
Notifications
You must be signed in to change notification settings - Fork 117
Add operator documentation (BETWEEN, LIKE, IN, IS DISTINCT FROM) #3762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add operator documentation (BETWEEN, LIKE, IN, IS DISTINCT FROM) #3762
Conversation
| FROM products | ||
| WHERE price BETWEEN 100 AND 150 | ||
| ORDER BY price | ||
| - supported_version: 4.3.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably redundant in light of having a file-level supported_version option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems all the yamsql files here have that. IIRC, few or all of these operators were there from before 4.3.5.0; in that case, we could remove the clause altogether just to not confuse it for the version the feature became available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, let me address that.
| SELECT * FROM products WHERE name = 'Widget' | ||
| SELECT * FROM products WHERE stock != 0 | ||
| IS DISTINCT FROM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the IS DISTINCT FROM operator is currently placed under Comparison Operators as well as described in its own page. However, the latter is more elaborate. Is this intentional in the sense that there should be a small summary of the operator in the Comparison Operators page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an earlier attempt at documenting IS DISTINCT FROM that I forgot about when writing a proper page. I think this can go away, or link to the page.
Thanks for catching that!
…documentation-queries.yamsql
Summary
Adds complete documentation for SQL operators: BETWEEN, LIKE, IN, and IS DISTINCT FROM.
Operators documented
Files