WIP Reintroduce Protobuf renaming, and a fix for deprecated types #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpliant names (FoundationDB#3736)" (FoundationDB#3767)" This reverts commit 7f1f4c9.
hatyo
force-pushed
the
reintroduce-proto-renaming
branch
from
c904633 to
51f58a7
Compare
Contributor
Author
|
PRB failed previously because of some code style violations and what seems to be a sporadic failure in |
hatyo
force-pushed
the
reintroduce-proto-renaming
branch
2 times, most recently
from
596d4c6 to
0f5589b
Compare
- make sure to convert FieldKeyExpression#fieldName (which is internal) to user-facing name when constructing match candidates. - also, add tests for deeply nested (and repeated) structures with non-pb-compliant field names, and an index.
hatyo
force-pushed
the
reintroduce-proto-renaming
branch
from
0f5589b to
e14e340
Compare
📊 Metrics Diff Analysis ReportSummary
ℹ️ About this analysisThis automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:
The last category in particular may indicate planner regressions that should be investigated. New QueriesCount of new queries by file:
|
Contributor
Author
|
Superseded by #3770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.