Draft: Mailsync support for US GCC environments in Office 365. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengotow
force-pushed
the
master
branch
2 times, most recently
from
8eacb98 to
06215f5
Compare
bengotow
force-pushed
the
master
branch
4 times, most recently
from
6166ef8 to
610cf83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are other GCC/secure clouds besides .us for Office 365, a better solution than attached to this pull request might be to add the token refresh url to the providers.json for oauth2 providers and "additional payload parameters" (though, you'll still need that special if statement for gmail).