feat: implement plan timeout verification methods#879
Merged
ONEONUORA merged 2 commits intoJun 28, 2026
Conversation
- Add is_plan_timed_out() query method to check if grace period has elapsed - Add get_timeout_deadline() method to return timeout timestamp - Both methods read ledger timestamp and compare with last_ping + grace_period - Existing claim() method already validates timeout before allowing claims - Add comprehensive test coverage (10 new tests): * Test timeout before, at, and after grace period * Test timeout behavior after ping resets timer * Test claim rejection/acceptance based on timeout status * Test error handling for non-existent plans Acceptance Criteria Met: Exposes query methods for external reads Reads current ledger timestamp Compares with last_ping + grace_period Returns boolean status Rejects claim operations if grace period has not elapsed
Contributor
Author
|
close #832 |
|
@Zarmaijemimah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Zarmaijemimah |
Contributor
|
@Zarmaijemimah |
ONEONUORA
approved these changes
Jun 28, 2026
Contributor
There was a problem hiding this comment.
Great job @Zarmaijemimah
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #832
feat: implement plan timeout verification methods