Refactor(registry): Optimize Profile Avatar URI Storage [SC-003]#410
Merged
Conversation
|
@TochukwuJustice Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…le, and ignore mock secrets
ONEONUORA
approved these changes
Jun 26, 2026
ONEONUORA
left a comment
ONEONUORA
left a comment
Contributor
There was a problem hiding this comment.
Great job @TochukwuJustice
Thank you for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #276
Summary of changes:
Removed the monolithic ADDRESS_TO_AVATAR map storage approach.
Introduced a strongly-typed DataKey::Avatar(Address) enum.
Refactored update_profile and get_avatar in the User Registry contract to directly read and write avatar URIs using granular composite storage keys.
Reason for the changes:$O(1)$ , significantly reducing gas costs and preventing the contract from hitting Soroban ledger limits as it scales.
The previous implementation utilized a single global Map to store every user's avatar. This meant that every profile update would load the entire platform's userbase into memory, update one entry, and serialize the entire Map back to persistent storage. This refactor changes the space and time complexity for avatar lookups/updates to a lean