Revert PR 1270: Direct access to current TCB inside stack macros #1272
+6
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeRTOS#1270)" This reverts commit 4162ca4.
|
kar-rahul-aws
approved these changes
May 2, 2025
AhmedIsmail02
approved these changes
May 2, 2025
There was a problem hiding this comment.
@aggarg Thank you for the changes, can you please fix the link-verifier CI check failure? I think it might be a transient error that might be fixed if restarted as they are all too-many-requests errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts PR 1270. As concluded in the discussion here, if
portSET_INTERRUPT_MASKandportCLEAR_INTERRUPT_MASKare implemented correctly to support recursive calls, this change is not needed.Test Steps
NA.
Checklist:
Related Issue
NA.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.