[Work In Progress] Adding the xPortIsInsideInterrupt to the PIC32MZ port #1300
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KammutierSpule
suggested changes
Aug 7, 2025
portable/MPLAB/PIC32MZ/port.c
Outdated
|
|
||
| /*-----------------------------------------------------------*/ | ||
|
|
||
| __attribute__((always_inline)) static BaseType_t xPortIsInsideInterrupt( void ) |
Contributor
There was a problem hiding this comment.
error: static declaration of 'xPortIsInsideInterrupt' follows non-static declaration
Member
Author
There was a problem hiding this comment.
This should be fixed now. I'm not sure if this should have been static in the first place.
kstribrnAmzn
force-pushed
the
pic32InInterrupt
branch
2 times, most recently
from
712d253 to
4028311
Compare
kstribrnAmzn
force-pushed
the
pic32InInterrupt
branch
from
c6dcf1f to
1143e6c
Compare
|
Member
Author
|
I'll move this back to draft until @KammutierSpule can confirm the function works with their setup. |
xTaskDelayUntil is more featured and should be preferred by new users. This change was inspired by https://forums.freertos.org/t/include-xtaskdelayuntil-vs-include-vtaskdelayuntil/24656.
kstribrnAmzn
force-pushed
the
pic32InInterrupt
branch
from
1143e6c to
3bfd03b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.