Skip to content

Add STM32 F411RE Nucleo 64 BG96 demo project #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

chinglee-iot
Copy link
Member

  • Add STM32 F411RE Nucleo 64 demo project
  • Add README.md document to describe how to integrate FreeRTOS libraries to existing code base from scratch.

@chinglee-iot chinglee-iot requested review from ActoryOu and removed request for ActoryOu July 13, 2022 09:03
@chinglee-iot chinglee-iot requested a review from ActoryOu July 14, 2022 07:38
*/
#define CELLULAR_IP_ADDRESS_MAX_SIZE ( 64U )

#define CELLULAR_CONFIG_DISABLE_FLOW_CONTROL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define CELLULAR_CONFIG_DISABLE_FLOW_CONTROL
/* STM32 F411RE doesn't support timer, so we need to disable flow control. */
#define CELLULAR_CONFIG_DISABLE_FLOW_CONTROL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to disable flow control is that the CTS/RTS pins are not connected together. I will add comments in the config.h file.

Comment on lines 63 to 66
/* Use 1NCE service to onboard device. */
#ifdef USE_1NCE_ZERO_TOUCH_PROVISIONING
#include "1nce_zero_touch_provisioning.h"
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these lines which are dedicated for 1NCE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed in new commit.

Comment on lines 488 to 500
#ifdef USE_1NCE_ZERO_TOUCH_PROVISIONING
uint8_t status = nce_onboard( &pThingName,
&pEndpoint,
&pExampleTopic,
&pRootCA,
&pClientCert,
&pPrvKey );
configASSERT( status == EXIT_SUCCESS );
#else
pThingName = democonfigCLIENT_IDENTIFIER;
pEndpoint = democonfigMQTT_BROKER_ENDPOINT;
pExampleTopic = mqttexampleTOPIC;
#endif /* ifdef USE_1NCE_ZERO_TOUCH_PROVISIONING */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed in new commit.

* User should reference the 1nce demo for if they are interesting in
  1nce
* Add comment in cellular_config.h
@chinglee-iot chinglee-iot requested a review from ActoryOu October 12, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants