Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate stylelintrc to stylint.config.js #6871

Merged

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Feb 22, 2025

Migrate stylelintrc to stylint.config.js

Pull Request Type

  • Other - maintenance/dev chore

Description

This PR migrates the stylelintrc file to a stylelint.config.mjs file. This is now the recommended format for stylelint. https://stylelint.io/user-guide/configure/

We can and probably should still use the .stylelintignore file. See the note here: https://stylelint.io/user-guide/configure/#ignorefiles

Testing

  • make a stylelint "error" in a css and scss file. ex: add a width property instead of inset-size
  • run yarn run lint-style and make sure the error shows

Desktop

  • OS: Fedora Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 22, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 22, 2025 01:53
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw it should be yarn run lint-style not npm

@FreeTubeBot FreeTubeBot merged commit 81e89e7 into FreeTubeApp:development Feb 23, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 23, 2025
@ChunkyProgrammer ChunkyProgrammer deleted the migrate-stylelint-config branch February 23, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants