Fix opening playlists in external players not working when ignore default args is enabled#8995
Open
absidue wants to merge 1 commit intoFreeTubeApp:developmentfrom
Open
Fix opening playlists in external players not working when ignore default args is enabled#8995absidue wants to merge 1 commit intoFreeTubeApp:developmentfrom
absidue wants to merge 1 commit intoFreeTubeApp:developmentfrom
Conversation
…ault args is enabled
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
and removed request for
kommunarr
github-actions
bot
added
the
PR: waiting for review
| } else if (!ignoreWarnings) { | ||
| unsupportedActions.push(UnsupportedPlayerActions.OPENING_PLAYLISTS) | ||
| } | ||
| } else { |
Member
There was a problem hiding this comment.
Should we keep the condition?
Suggested change
| } else { | |
| } else if (hasValidVideoId) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Currently if the "Ignore Default Arguments" setting is enabled and you try to open a playlist in an external player it silently fails. With this change it will open the playlist if only a playlist ID is available such as trying to open a playlist in the external player, but will open the video if no playlist ID is passed or if both a playlist ID and video ID are passed, the latter differs from the default behaviour, as the "Ignore Default Arguments" setting means we are not allowed to pass an extra argument to indicate which video in the playlist to open.
Testing
Desktop