feat: add logger for warnings and errors withing cached result, introduce dedicated endpoint to get just the health state #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duce dedicated endpoint to get just the health state
tinect
changed the title
shyim
reviewed
Feb 8, 2025
|
|
||
| if ($healthStatus->count() > 0) { | ||
| if ($state === SettingsResult::ERROR) { | ||
| $this->froshToolsLogger->error('Health check', ['results' => $healthStatus]); |
There was a problem hiding this comment.
this will log it every x minutes sounds useless
There was a problem hiding this comment.
I thought: when would be a better time? 🙈 always is really dump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logging, we could dispatch an event?