Skip to content

[DOI-2558] Validate queries against SPs (Unsubscribers and Spam) #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emoralesms merged 4 commits into from
Dec 5, 2025
Merged

[DOI-2558] Validate queries against SPs (Unsubscribers and Spam) #99

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2103ad
fix: queries
emoralesms Dec 3, 2025
44c9b70
fix: syntax and add idsubscribersstatus five
emoralesms Dec 4, 2025
69d868f
chore: test 4
emoralesms Dec 4, 2025
e6693bc
chore: test 5
emoralesms Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 50 additions & 61 deletions Doppler.ReportingApi/Infrastructure/CampaignRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,14 @@ public async Task<List<SentCampaignMetrics>> GetSentCampaignsMetrics(string user
{
var dummyDatabaseQuery = @"
DECLARE @timezone INT
DECLARE @idUser INT

SELECT @timezone = offset
SELECT
@timezone = offset
,@idUser = u.IdUser
FROM dbo.usertimezone timezone
INNER JOIN dbo.[user] u ON u.idusertimezone = timezone.idusertimezone
WHERE u.[Email] = @userName
WHERE u.[Email] = @userName;

SELECT
RPT.[IdUser]
Expand Down Expand Up @@ -174,13 +177,13 @@ END AS [SpamRate]
,C.[FromEmail]
,C.[CampaignType]
,ISNULL(C.[AmountSubscribersToSend],0) [Subscribers]
,ISNULL(C.[AmountSentSubscribers],0) [Sent]
,(ISNULL(C.[DistinctOpenedMailCount],0) + ISNULL(C.[UnopenedMailCount],0)) AS [Sent]
,ISNULL(C.[DistinctOpenedMailCount],0) [Opens]
,ISNULL(C.[DistinctClickCount],0) [Clicks]
,ISNULL(C.[HardBouncedMailCount],0) [Hard]
,ISNULL (C.[SoftBouncedMailCount],0) [Soft]
,ISNULL(C.[UnsubscriptionsCount],0) [Unsubscribes]
,0 [Spam]
,ISNULL(C.[UnsubscriptionsCount], Unsubscribes.Unsubscribes) [Unsubscribes]
,Unsubscribes.Spam [Spam]
,L.[Name] [LabelName]
,LC.[Colour] [LabelColour]
FROM [dbo].[Campaign] C WITH (NOLOCK)
Expand All @@ -190,6 +193,31 @@ LEFT JOIN [dbo].[Label] L WITH (NOLOCK)
ON C.[IdLabel] = L.[IdLabel]
LEFT JOIN [dbo].[Colour] LC WITH (NOLOCK)
ON L.[IdColour] = LC.[IdColour]
LEFT JOIN (
SELECT
COUNT(
CASE
WHEN S.IdUnsubscriptionReason <> 2
AND S.UnsubscriptionSubreason NOT IN (2,3,4)
THEN 1
END
) [Unsubscribes]
,COUNT(
CASE
WHEN S.IdUnsubscriptionReason = 2
OR S.UnsubscriptionSubreason IN (2,3,4)
THEN 1
END
) [Spam]
,c.IdCampaign
FROM dbo.campaign c
INNER JOIN dbo.subscriber s ON c.idcampaign = s.IdCampaign
WHERE c.iduser = @idUser
AND c.STATUS in (5, 9)
AND c.IdTestCampaign IS NULL
AND s.IdSubscribersStatus = 5
GROUP BY c.IdCampaign
) Unsubscribes ON c.idcampaign = Unsubscribes.IdCampaign
WHERE
U.[Email] = @userName
AND C.[Status] IN (5,9)
Expand All @@ -206,58 +234,6 @@ AND C.[IdScheduledTask] IS NULL
@labelsCount = 0
OR C.[IdLabel] IN @labels
)
UNION ALL
SELECT
S.[IdUser]
,S.[IdCampaign]
,C.[Name]
,C.[UTCScheduleDate]
,C.[FromEmail]
,C.[CampaignType]
,0 [Subscribers]
,0 [Sent]
,0 [Opens]
,0 [Clicks]
,0 [Hard]
,0 [Soft]
,0 [Unsubscribes]
,COUNT(1) [Spam]
,L.[Name] [LabelName]
,LC.[Colour] [LabelColour]
FROM [dbo].[Subscriber] S WITH (NOLOCK)
JOIN [dbo].[Campaign] C WITH (NOLOCK)
ON S.[IdUser] = C.[IdUser] AND S.[IdCampaign] = C.[IdCampaign]
JOIN [dbo].[User] U WITH (NOLOCK)
ON S.[IdUser] = U.[IdUser]
LEFT JOIN [dbo].[Label] L WITH (NOLOCK)
ON C.[IdLabel] = L.[IdLabel]
LEFT JOIN [dbo].[Colour] LC WITH (NOLOCK)
ON L.[IdColour] = LC.[IdColour]
WHERE
U.[Email] = @userName
AND C.[Status] IN (5,9)
AND C.Active = 1
AND (@startDate IS NULL OR C.[UTCScheduleDate] >= @startDate)
AND (@endDate IS NULL OR C.[UTCScheduleDate] <= @endDate)
AND (@campaignName IS NULL OR LOWER(LTRIM(RTRIM(C.[Name]))) LIKE '%' + LOWER(LTRIM(RTRIM(@campaignName))) + '%')
AND (@campaignType IS NULL OR C.[CampaignType] LIKE @campaignType)
AND (@fromEmail IS NULL OR LOWER(LTRIM(RTRIM(C.[FromEmail]))) LIKE LOWER(LTRIM(RTRIM(@fromEmail))))
AND C.[IdTestCampaign] IS NULL
AND C.[IdScheduledTask] IS NULL
AND (C.TestABCategory IS NULL OR C.TestABCategory = 3)
AND (
@labelsCount = 0
OR C.[IdLabel] IN @labels
)
GROUP BY
S.[IdUser]
,S.[IdCampaign]
,C.[Name]
,C.[UTCScheduleDate]
,C.[FromEmail]
,C.[CampaignType]
,L.[Name]
,LC.[Colour]
) RPT
GROUP BY RPT.[IdUser]
,RPT.[IdCampaign]
Expand Down Expand Up @@ -372,7 +348,7 @@ END AS [SpamRate]
,C.[IdCampaign]
,C.[UTCScheduleDate]
,ISNULL(C.[AmountSubscribersToSend],0) [Subscribers]
,ISNULL(C.[AmountSentSubscribers],0) [Sent]
,(ISNULL(C.[DistinctOpenedMailCount],0) + ISNULL(C.[UnopenedMailCount],0)) AS [Sent]
,ISNULL(C.[DistinctOpenedMailCount],0) [Opens]
,ISNULL(C.[DistinctClickCount],0) [Clicks]
,ISNULL(C.[HardBouncedMailCount],0) [Hard]
Expand Down Expand Up @@ -402,11 +378,23 @@ UNION ALL
,0 [Clicks]
,0 [Hard]
,0 [Soft]
,0 [Unsubscribes]
,COUNT(1) [Spam]
,COUNT(
CASE
WHEN S.IdUnsubscriptionReason <> 2
AND S.UnsubscriptionSubreason NOT IN (2,3,4)
THEN 1
END
) [Unsubscribes]
,COUNT(
CASE
WHEN S.IdUnsubscriptionReason = 2
OR S.UnsubscriptionSubreason IN (2,3,4)
THEN 1
END
) [Spam]
FROM [dbo].[Subscriber] S WITH (NOLOCK)
JOIN [dbo].[Campaign] C WITH (NOLOCK)
ON S.[IdUser] = S.[IdUser] AND S.[IdCampaign] = C.[IdCampaign]
ON S.[IdUser] = C.[IdUser] AND S.[IdCampaign] = C.[IdCampaign]
JOIN [dbo].[User] U WITH (NOLOCK)
ON S.[IdUser] = U.[IdUser]
WHERE
Expand All @@ -418,6 +406,7 @@ AND C.[Status] IN (5,9)
AND C.[IdTestCampaign] IS NULL
AND C.[IdScheduledTask] IS NULL
AND (C.TestABCategory IS NULL OR C.TestABCategory = 3)
AND S.IdSubscribersStatus = 5
GROUP BY
S.[IdUser]
,S.[IdCampaign]
Expand Down