fix(fuel-streams-subject): Add alias and validate payload conversion #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronauck
requested review from
luizstacio,
0xterminator,
cue8it and
rodrigobranas
as code owners
rodrigobranas
previously approved these changes
Feb 20, 2025
pedronauck
dismissed stale reviews from 0xterminator and rodrigobranas
via
c181e88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the conversion from
SubjectPayloadintoSubjectis valid. Before this an invalidparams: {}object could be passed in the webserver and nothing was happening, now the validation in happening and we introduce asubject(alias = "")to determine which other name a field can have when validating (like serde does)