Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check and store package dependencies in database #29

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jan 29, 2025

Closes #27

  • Adds the package_dependencies table
  • Adds the readme and forc_manifest columns to uploads and populates them during the upload API
  • Populates the dependencies table by parsing the forc manifest and ensuring all dependencies have a version and are present in the registry
  • Refactors handler code under src/handlers

Notes

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forc-pub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 4:04am

@sdankel sdankel marked this pull request as ready for review February 7, 2025 21:01
@sdankel sdankel requested a review from a team February 7, 2025 21:02
JoshuaBatty
JoshuaBatty previously approved these changes Feb 8, 2025
Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

zees-dev
zees-dev previously approved these changes Feb 9, 2025
Copy link

@zees-dev zees-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues; no blockers though; nice work; LGTM!

@sdankel sdankel merged commit 40456b0 into master Feb 11, 2025
11 checks passed
sdankel added a commit to FuelLabs/sway that referenced this pull request Feb 11, 2025
## Description

Closes #6889

Currently it only works when running locally, as the forc.pub server is
not yet live. Allows users to publish a package by running `forc
publish` in the root of the package directory. Workspaces not yet
supported.

It's intentionally not yet added to the release process (will be done in
#6891)

To test it locally, run the
[forc.pub](https://github.com/FuelLabs/forc.pub/) server and web app
locally (see that repo's README for more details).

1. Start DB ./scripts/start_local_db.sh
2. Start server cargo run
3. Start frontend cd app && npm start - opens localhost:3000
4. Get API token from local webapp -> Login with Github -> API Tokens ->
Generate new token
5. Edit `std-lib-core/Forc.toml` and add a version key, i.e. `version =
0.1.0`
6. Run `forc publish` from this branch:
FuelLabs/forc.pub#29 and you'll be prompted to
enter the token.

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Marcos Henrich <[email protected]>
Co-authored-by: Joshua Batty <[email protected]>
Co-authored-by: Kaya Gökalp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add package dependencies table
3 participants