Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed redundant evm-connector #475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Feb 10, 2025

Summary

  • The @fuel-connectors/evm-connector package is unused and not exported; therefore I removed it.

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@petertonysmith94 petertonysmith94 self-assigned this Feb 10, 2025
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 4:54pm

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.63% 143 / 232
🔵 Statements 61.63% 143 / 232
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #1400 for commit b4e359e by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1400 for commit b4e359e by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 24 / 24
🔵 Statements 100% 24 / 24
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1400 for commit b4e359e by the Vitest Coverage Report Action

@petertonysmith94 petertonysmith94 changed the title chore: removed redundant evm-connector chore: removed redundant evm-connector Feb 10, 2025
@LuizAsFight
Copy link
Contributor

hey @petertonysmith94 thanks for the PR

so the original idea of this connector is to a more pure integration without using walletconnect, where it can be used in nodejs also

@petertonysmith94
Copy link
Contributor Author

hey @petertonysmith94 thanks for the PR

so the original idea of this connector is to a more pure integration without using walletconnect, where it can be used in nodejs also

That is interesting. Is there a plan to roll this out as exported functionality?

@helciofranco
Copy link
Member

@LuizAsFight we don't export it currently. no one is using it.

package/connectors/src/index.ts
Screenshot 2025-02-12 at 12 35 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants