-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL extension to provide current STF and CP versions #2715
Open
rafal-ch
wants to merge
37
commits into
master
Choose a base branch
from
rafal/2596_additional_graphql_extensions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+696
−187
Open
Changes from 36 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
cc4e8c2
Introduce separate module for GraphQL extensions
rafal-ch 3b48d47
Revert changes to test structure
rafal-ch 9bd97b7
Add scaffolding for the `current_stf_version` extension
rafal-ch ac861c4
Add possible way to go with the SFT update notification
rafal-ch c022ba7
Add `current_consensus_parameters_version` GraphQL extension
rafal-ch 56d4c57
Elaborate on the possible ways to go for STF
rafal-ch 51237b3
Use `latest_consensus_parameters_version()` instead of `latest_consen…
rafal-ch 335b243
Add `current_stf_version` GraphQL extension
rafal-ch 946e315
Update comment
rafal-ch 2616cd7
Update changelog
rafal-ch da57953
Merge remote-tracking branch 'upstream/master' into rafal/2596_additi…
rafal-ch 2772ba7
Add test checking that proper consensus parameters version is returne…
rafal-ch 3359d61
Add test checking that proper stf version is returned via GraphQL ext…
rafal-ch d51222f
Clean-up
rafal-ch 5c24c74
Merge remote-tracking branch 'origin/master' into rafal/2596_addition…
rafal-ch bd610e7
Merge STF and CP extensions into one
rafal-ch 3f3e971
Provide current block height via 'chain state info' extension
rafal-ch c3c0148
Typos
rafal-ch ef9c445
Access latest STF and CP version via `FuelClient`
rafal-ch b861a51
Cache STF version in consensus parameters provider
rafal-ch 0b27037
Move all GraphQL extensions into a single place
rafal-ch 946fc41
Worker service now uses STF provider, not ConsensusParameters provider
rafal-ch accfae0
Unify `current` vs `latest` naming in the code around grapqhql extens…
rafal-ch 4cd21b4
Merge remote-tracking branch 'origin/master' into rafal/2596_addition…
rafal-ch bbecdb8
Update changelog according to the new changelog management system
rafal-ch e0f21bf
Merge remote-tracking branch 'origin/master' into rafal/2596_addition…
rafal-ch 6d1ec52
Move const into the test code
rafal-ch 3f32362
Remove unnecessary comment
rafal-ch d8ea573
`ConsensusParametersProvider` uses `RwLock` instead of `Mutex`
rafal-ch 69b0da5
Match all variants explicitly
rafal-ch 3aa2d2d
Chain state info is updated in `decode_response` to also be included …
rafal-ch e03baac
Fix formatting
rafal-ch 932a1c5
Do not add ConsensusParametersProvider to worker service
rafal-ch ed1dd26
Clean-up
rafal-ch bfc5f58
Clean-up
rafal-ch 03f9645
Merge remote-tracking branch 'origin/master' into rafal/2596_addition…
rafal-ch b44cac9
Applied comments from the PR
xgreenx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Each GraphQL response contains `current_consensus_parameters_version` and `current_stf_version` in the `extensions` section. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
pub(crate) mod chain_state_info; | ||
pub(crate) mod metrics; | ||
pub(crate) mod required_fuel_block_height; | ||
pub(crate) mod validation; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are able to use
&self
, then you can removeinner_required_height
(move logic insideupdate_chain_state_info
) and update everything in one function=)