-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove redundant gas price call for tx summary #3559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielbate
commented
Jan 7, 2025
packages/account/src/providers/transaction-summary/assemble-transaction-summary.test.ts
Show resolved
Hide resolved
danielbate
commented
Jan 7, 2025
packages/account/src/providers/transaction-summary/assemble-transaction-summary.test.ts
Show resolved
Hide resolved
danielbate
commented
Jan 7, 2025
packages/account/src/providers/transaction-summary/assemble-transaction-summary.ts
Outdated
Show resolved
Hide resolved
danielbate
commented
Jan 7, 2025
packages/account/src/providers/transaction-summary/calculate-tx-fee-for-summary.ts
Show resolved
Hide resolved
danielbate
commented
Jan 7, 2025
danielbate
changed the title
feat: remove redundant gas price call for tx summary
feat!: remove redundant gas price call for tx summary
Jan 7, 2025
…/feat/remove-redundant-gas-price-call
…hub.com/FuelLabs/fuels-ts into db/feat/remove-redundant-gas-price-call
danielbate
commented
Jan 7, 2025
danielbate
requested review from
digorithm,
arboleya and
Torres-ssf
as code owners
January 7, 2025 17:17
nedsalk
reviewed
Jan 8, 2025
Co-authored-by: Nedim Salkić <[email protected]>
nedsalk
previously approved these changes
Jan 8, 2025
nedsalk
approved these changes
Jan 8, 2025
Torres-ssf
approved these changes
Jan 8, 2025
petertonysmith94
approved these changes
Jan 8, 2025
Coverage Report:
Changed Files:
|
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionResponse
#3536Release notes
In this release, we:
Summary
Removes a redundant get latest gas price network call for transactions that have settled, where we can obtain the fee from the status check, rather than recalculating it.
Breaking Changes
calculateTXFeeForSummary
and subsequently theCalculateTXFeeForSummaryParams
no longer accept atotalFee
property. If you have thetotalFee
, then there is no need to call thecalculateTxFeeForSummary()
function.Checklist