Add interactive ABI for calling contract methods #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e37f8f.
kayagokalp
approved these changes
Jun 8, 2023
| setResults([<>Add some code to compile.</>]); | ||
| return; | ||
| } | ||
|
|
||
| setResults([<>Compiling...</>]); | ||
|
|
||
| // TODO: Determine the URL based on the NODE_ENV. | ||
| const server_uri = 'https://api.sway-playground.org/compile'; | ||
| // const server_uri = 'https://127.0.0.1/compile'; |
There was a problem hiding this comment.
Should we keep this line seems like left from debugging
There was a problem hiding this comment.
This prints Compiling... in the console that the user sees, so it's useful to keep it in :)
There was a problem hiding this comment.
Oh I meant line 48, but nothing important 🙌
JoshuaBatty
approved these changes
Jun 8, 2023
Agreed! #10 |
This was referenced Jun 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the idea from https://github.com/FuelLabs/sway-playground/pull/2/files
This PR adds an "Interact" button that opens a drawer with the ability to call all of the functions in the ABI. For complex arguments (enums, structs, vectors, and options), there is a JSON editor where the user can supply the input. The JSON editor has a default value populated based on the schema of the input, making it easier to tell what a proper input should look like.
Also restyled the compile button, replaced the logo with the sway logo, and fixed a DOM error by importing
'ace-builds/webpack-resolver'before other ace-build imports.Tested locally with the production build to make sure it's all working with the static webpack JS. It's deployed here if you want to play with it: https://sway-playground-sdankel.vercel.app/
To test it locally, just do:
Consistency with Fuel UI
I decided not to use
fuel-ui/reactsince it added 4MB to the bundle size (without it, it's <2MB). Bundle size is important since it affects how fast the app feels to the users. 6MB is very large. The majority of the size came from thephosphorusdependency infuel-ui/react, which imports ALL of the phosphorus icons into the browser. As an alternative I used Material UI which allows you to import only the icons you need.I would like to use the shared fuel React components, but not at the cost of making the app run unnecessarily slow. I would suggest that we switch
fuel-ui/reactto use Material UI for icons (and maybe other components!?) since it makes it easy to optimize bundle size, it looks good, has great documentation, and is totally free.I did use
fuel-ui/cssfor the colors.Follow up: #8
Feedback
From @SilentCicero
forc test#7Getting to the interact panel: compile & deploy
Dry run call (default)
Live call