Skip to content

Refactor: Replace hardcoded colors with CSS variables across all project pages #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HUAHUAI23 merged 3 commits into from
Nov 6, 2025
Merged

Refactor: Replace hardcoded colors with CSS variables across all project pages #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
282bd00
feat: refactor NoProject component and improve VS Code-style alignment
norberia Nov 6, 2025
e2046aa
refactor: replace hardcoded colors with CSS variables across all proj…
norberia Nov 6, 2025
2e42f56
Reorder import statements in projects page
norberia Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
246 changes: 146 additions & 100 deletions app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,120 +3,166 @@

@custom-variant dark (&:is(.dark *));

:root {
--background: oklch(1.00 0 0);
--foreground: oklch(0.32 0 0);
--card: oklch(1.00 0 0);
--card-foreground: oklch(0.32 0 0);
--popover: oklch(1.00 0 0);
--popover-foreground: oklch(0.32 0 0);
--primary: oklch(0.62 0.19 259.76);
--primary-foreground: oklch(1.00 0 0);
--secondary: oklch(0.97 0 0);
--secondary-foreground: oklch(0.45 0.03 257.68);
--muted: oklch(0.98 0 0);
--muted-foreground: oklch(0.55 0.02 264.41);
--accent: oklch(0.95 0.03 233.56);
--accent-foreground: oklch(0.38 0.14 265.59);
--destructive: oklch(0.64 0.21 25.39);
--border: oklch(0.93 0.01 261.82);
--input: oklch(0.93 0.01 261.82);
--ring: oklch(0.62 0.19 259.76);
--chart-1: oklch(0.62 0.19 259.76);
--chart-2: oklch(0.55 0.22 262.96);
--chart-3: oklch(0.49 0.22 264.43);
--chart-4: oklch(0.42 0.18 265.55);
--chart-5: oklch(0.38 0.14 265.59);
--sidebar: oklch(0.98 0 0);
--sidebar-foreground: oklch(0.14 0 0);
--sidebar-primary: oklch(0.20 0 0);
--sidebar-primary-foreground: oklch(0.98 0 0);
--sidebar-accent: oklch(0.97 0 0);
--sidebar-accent-foreground: oklch(0.20 0 0);
--sidebar-border: oklch(0.92 0 0);
--sidebar-ring: oklch(0.71 0 0);
--destructive-foreground: oklch(1.0000 0 0);
--font-serif: Source Serif 4, serif;
--font-mono: JetBrains Mono, monospace;
--radius: 0.375rem;
--shadow-2xs: 0px 4px 8px -1px hsl(0 0% 0% / 0.05);
--shadow-xs: 0px 4px 8px -1px hsl(0 0% 0% / 0.05);
--shadow-sm: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 1px 2px -2px hsl(0 0% 0% / 0.10);
--shadow: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 1px 2px -2px hsl(0 0% 0% / 0.10);
--shadow-md: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 2px 4px -2px hsl(0 0% 0% / 0.10);
--shadow-lg: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 4px 6px -2px hsl(0 0% 0% / 0.10);
--shadow-xl: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 8px 10px -2px hsl(0 0% 0% / 0.10);
--shadow-2xl: 0px 4px 8px -1px hsl(0 0% 0% / 0.25);
--tracking-normal: 0em;
}

.dark {
--background: oklch(0.20 0 0);
--foreground: oklch(0.92 0 0);
--card: oklch(0.27 0 0);
--card-foreground: oklch(0.92 0 0);
--popover: oklch(0.27 0 0);
--popover-foreground: oklch(0.92 0 0);
--primary: oklch(0.62 0.19 259.76);
--primary-foreground: oklch(1.00 0 0);
--secondary: oklch(0.27 0 0);
--secondary-foreground: oklch(0.92 0 0);
--muted: oklch(0.27 0 0);
--muted-foreground: oklch(0.72 0 0);
--accent: oklch(0.38 0.14 265.59);
--accent-foreground: oklch(0.88 0.06 254.63);
--destructive: oklch(0.64 0.21 25.39);
--border: oklch(0.37 0 0);
--input: oklch(0.37 0 0);
--ring: oklch(0.62 0.19 259.76);
--chart-1: oklch(0.71 0.14 254.69);
--chart-2: oklch(0.62 0.19 259.76);
--chart-3: oklch(0.55 0.22 262.96);
--chart-4: oklch(0.49 0.22 264.43);
--chart-5: oklch(0.42 0.18 265.55);
--sidebar: oklch(0.21 0.01 285.93);
--sidebar-foreground: oklch(0.99 0 0);
--sidebar-primary: oklch(0.49 0.24 264.40);
--sidebar-primary-foreground: oklch(0.99 0 0);
--sidebar-accent: oklch(0.27 0.01 286.10);
--sidebar-accent-foreground: oklch(0.99 0 0);
--sidebar-border: oklch(1.00 0 0 / 10%);
--sidebar-ring: oklch(0.55 0.02 285.93);
--destructive-foreground: oklch(1.0000 0 0);
--font-serif: Source Serif 4, serif;
--font-mono: JetBrains Mono, monospace;
--radius: 0.375rem;
--shadow-2xs: 0px 4px 8px -1px hsl(0 0% 0% / 0.05);
--shadow-xs: 0px 4px 8px -1px hsl(0 0% 0% / 0.05);
--shadow-sm: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 1px 2px -2px hsl(0 0% 0% / 0.10);
--shadow: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 1px 2px -2px hsl(0 0% 0% / 0.10);
--shadow-md: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 2px 4px -2px hsl(0 0% 0% / 0.10);
--shadow-lg: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 4px 6px -2px hsl(0 0% 0% / 0.10);
--shadow-xl: 0px 4px 8px -1px hsl(0 0% 0% / 0.10), 0px 8px 10px -2px hsl(0 0% 0% / 0.10);
--shadow-2xl: 0px 4px 8px -1px hsl(0 0% 0% / 0.25);
}

@theme inline {
--color-background: var(--background);
--color-foreground: var(--foreground);
--font-sans: var(--font-geist-sans);
--font-mono: var(--font-geist-mono);
--color-sidebar-ring: var(--sidebar-ring);
--color-sidebar-border: var(--sidebar-border);
--color-sidebar-accent-foreground: var(--sidebar-accent-foreground);
--color-sidebar-accent: var(--sidebar-accent);
--color-sidebar-primary-foreground: var(--sidebar-primary-foreground);
--color-sidebar-primary: var(--sidebar-primary);
--color-sidebar-foreground: var(--sidebar-foreground);
--color-sidebar: var(--sidebar);
--color-chart-5: var(--chart-5);
--color-chart-4: var(--chart-4);
--color-chart-3: var(--chart-3);
--color-chart-2: var(--chart-2);
--color-chart-1: var(--chart-1);
--color-ring: var(--ring);
--color-input: var(--input);
--color-border: var(--border);
--color-destructive: var(--destructive);
--color-accent-foreground: var(--accent-foreground);
--color-accent: var(--accent);
--color-muted-foreground: var(--muted-foreground);
--color-muted: var(--muted);
--color-secondary-foreground: var(--secondary-foreground);
--color-secondary: var(--secondary);
--color-primary-foreground: var(--primary-foreground);
--color-primary: var(--primary);
--color-popover-foreground: var(--popover-foreground);
--color-popover: var(--popover);
--color-card-foreground: var(--card-foreground);
--color-card: var(--card);
--color-card-foreground: var(--card-foreground);
--color-popover: var(--popover);
--color-popover-foreground: var(--popover-foreground);
--color-primary: var(--primary);
--color-primary-foreground: var(--primary-foreground);
--color-secondary: var(--secondary);
--color-secondary-foreground: var(--secondary-foreground);
--color-muted: var(--muted);
--color-muted-foreground: var(--muted-foreground);
--color-accent: var(--accent);
--color-accent-foreground: var(--accent-foreground);
--color-destructive: var(--destructive);
--color-border: var(--border);
--color-input: var(--input);
--color-ring: var(--ring);
--color-chart-1: var(--chart-1);
--color-chart-2: var(--chart-2);
--color-chart-3: var(--chart-3);
--color-chart-4: var(--chart-4);
--color-chart-5: var(--chart-5);
--color-sidebar: var(--sidebar);
--color-sidebar-foreground: var(--sidebar-foreground);
--color-sidebar-primary: var(--sidebar-primary);
--color-sidebar-primary-foreground: var(--sidebar-primary-foreground);
--color-sidebar-accent: var(--sidebar-accent);
--color-sidebar-accent-foreground: var(--sidebar-accent-foreground);
--color-sidebar-border: var(--sidebar-border);
--color-sidebar-ring: var(--sidebar-ring);
--color-destructive-foreground: var(--destructive-foreground);
--font-sans: var(--font-sans);
--font-mono: var(--font-mono);
--font-serif: var(--font-serif);
--radius-sm: calc(var(--radius) - 4px);
--radius-md: calc(var(--radius) - 2px);
--radius-lg: var(--radius);
--radius-xl: calc(var(--radius) + 4px);
}

:root {
--radius: 0.625rem;
--background: oklch(1 0 0);
--foreground: oklch(0.145 0 0);
--card: oklch(1 0 0);
--card-foreground: oklch(0.145 0 0);
--popover: oklch(1 0 0);
--popover-foreground: oklch(0.145 0 0);
--primary: oklch(0.205 0 0);
--primary-foreground: oklch(0.985 0 0);
--secondary: oklch(0.97 0 0);
--secondary-foreground: oklch(0.205 0 0);
--muted: oklch(0.97 0 0);
--muted-foreground: oklch(0.556 0 0);
--accent: oklch(0.97 0 0);
--accent-foreground: oklch(0.205 0 0);
--destructive: oklch(0.577 0.245 27.325);
--border: oklch(0.922 0 0);
--input: oklch(0.922 0 0);
--ring: oklch(0.708 0 0);
--chart-1: oklch(0.646 0.222 41.116);
--chart-2: oklch(0.6 0.118 184.704);
--chart-3: oklch(0.398 0.07 227.392);
--chart-4: oklch(0.828 0.189 84.429);
--chart-5: oklch(0.769 0.188 70.08);
--sidebar: oklch(0.985 0 0);
--sidebar-foreground: oklch(0.145 0 0);
--sidebar-primary: oklch(0.205 0 0);
--sidebar-primary-foreground: oklch(0.985 0 0);
--sidebar-accent: oklch(0.97 0 0);
--sidebar-accent-foreground: oklch(0.205 0 0);
--sidebar-border: oklch(0.922 0 0);
--sidebar-ring: oklch(0.708 0 0);
}

.dark {
--background: oklch(0.145 0 0);
--foreground: oklch(0.985 0 0);
--card: oklch(0.205 0 0);
--card-foreground: oklch(0.985 0 0);
--popover: oklch(0.205 0 0);
--popover-foreground: oklch(0.985 0 0);
--primary: oklch(0.922 0 0);
--primary-foreground: oklch(0.205 0 0);
--secondary: oklch(0.269 0 0);
--secondary-foreground: oklch(0.985 0 0);
--muted: oklch(0.269 0 0);
--muted-foreground: oklch(0.708 0 0);
--accent: oklch(0.269 0 0);
--accent-foreground: oklch(0.985 0 0);
--destructive: oklch(0.704 0.191 22.216);
--border: oklch(1 0 0 / 10%);
--input: oklch(1 0 0 / 15%);
--ring: oklch(0.556 0 0);
--chart-1: oklch(0.488 0.243 264.376);
--chart-2: oklch(0.696 0.17 162.48);
--chart-3: oklch(0.769 0.188 70.08);
--chart-4: oklch(0.627 0.265 303.9);
--chart-5: oklch(0.645 0.246 16.439);
--sidebar: oklch(0.205 0 0);
--sidebar-foreground: oklch(0.985 0 0);
--sidebar-primary: oklch(0.488 0.243 264.376);
--sidebar-primary-foreground: oklch(0.985 0 0);
--sidebar-accent: oklch(0.269 0 0);
--sidebar-accent-foreground: oklch(0.985 0 0);
--sidebar-border: oklch(1 0 0 / 10%);
--sidebar-ring: oklch(0.556 0 0);
--shadow-2xs: var(--shadow-2xs);
--shadow-xs: var(--shadow-xs);
--shadow-sm: var(--shadow-sm);
--shadow: var(--shadow);
--shadow-md: var(--shadow-md);
--shadow-lg: var(--shadow-lg);
--shadow-xl: var(--shadow-xl);
--shadow-2xl: var(--shadow-2xl);
}

@layer base {
* {
@apply border-border outline-ring/50;
}
body {
@apply bg-background text-foreground;
@apply bg-background text-foreground/90;

Copilot AI Nov 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body text uses text-foreground/90 (90% opacity) but throughout the component files, text is being changed to text-foreground at 100% opacity. This inconsistency could lead to unexpected text rendering. Consider whether body text should be at full opacity or if component text should inherit this 90% opacity.

Suggested change
@apply bg-background text-foreground/90;
@apply bg-background text-foreground;

Copilot uses AI. Check for mistakes.
}
h1 {
@apply scroll-m-20 text-4xl tracking-tight text-balance;
}
h2 {
@apply scroll-m-20 text-3xl tracking-tight first:mt-0;
}
p {
@apply leading-7 [&:not(:first-child)]:mt-6 text-muted-foreground;

Copilot AI Nov 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global p tag style applies text-muted-foreground to all paragraphs, but many component changes explicitly set paragraph text to text-muted-foreground (e.g., line 56 in app/projects/page.tsx). This creates redundancy and could cause confusion about the actual text color source. Consider whether the global style is needed or if explicit component styling should be removed.

Suggested change
@apply leading-7 [&:not(:first-child)]:mt-6 text-muted-foreground;
@apply leading-7 [&:not(:first-child)]:mt-6;

Copilot uses AI. Check for mistakes.
}
span {
@apply text-muted-foreground;
}
Comment thread
HUAHUAI23 marked this conversation as resolved.
}
26 changes: 13 additions & 13 deletions app/projects/[id]/environment/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,29 +84,29 @@ export default function EnvironmentPage() {

if (loading) {
return (
<div className="min-h-screen bg-black text-white flex items-center justify-center">
<div className="min-h-screen bg-background text-foreground flex items-center justify-center">
<p>Loading...</p>
</div>
);
}

return (
<div className="min-h-screen bg-black text-white">
<div className="min-h-screen bg-background text-foreground">
<div className="container mx-auto py-8 px-4">
<div className="mb-8">
<h1 className="text-3xl font-bold mb-2">Environment Variables</h1>
<p className="text-gray-400">
<p className="text-muted-foreground">
Configure custom environment variables for your application
</p>
</div>

<Card className="bg-gray-900 border-gray-800">
<Card className="bg-card border-border">
<CardHeader>
<CardTitle className="text-white flex items-center gap-2">
<CardTitle className="text-foreground flex items-center gap-2">
<Key className="h-5 w-5" />
Custom Environment Variables
</CardTitle>
<CardDescription className="text-gray-400">
<CardDescription className="text-muted-foreground">
Add your application-specific environment variables. For authentication and payment
configurations, use their dedicated pages.
</CardDescription>
Expand All @@ -124,33 +124,33 @@ export default function EnvironmentPage() {
e.target.value.toUpperCase().replace(/[^A-Z0-9_]/g, '_')
)
}
className="bg-gray-800 border-gray-700 text-white font-mono col-span-4"
className="bg-background border-input text-foreground font-mono col-span-4"
/>
<Input
placeholder="Value"
value={env.value}
onChange={(e) => updateEnvVar(index, 'value', e.target.value)}
className="bg-gray-800 border-gray-700 text-white col-span-7"
className="bg-background border-input text-foreground col-span-7"
/>
<Button
variant="outline"
size="icon"
onClick={() => removeEnvVar(index)}
className="border-gray-700 text-white hover:bg-gray-800 col-span-1"
className="border-border text-foreground hover:bg-accent col-span-1"
>
<Trash2 className="h-4 w-4" />
</Button>
</div>
))}
{envVars.length === 0 && (
<div className="text-center py-8 text-gray-500">
<div className="text-center py-8 text-muted-foreground">
No custom environment variables configured yet
</div>
)}
<Button
onClick={addEnvVar}
variant="outline"
className="border-gray-700 text-white hover:bg-gray-800"
className="border-border text-foreground hover:bg-accent"
>
<Plus className="mr-2 h-4 w-4" />
Add Variable
Expand All @@ -162,15 +162,15 @@ export default function EnvironmentPage() {
<Button
onClick={saveEnvironment}
disabled={saving}
className="bg-white text-black hover:bg-gray-200"
className="bg-primary hover:bg-primary/90 text-primary-foreground"
>
<Save className="mr-2 h-4 w-4" />
{saving ? 'Saving...' : 'Save Environment'}
</Button>
<Button
onClick={() => router.back()}
variant="outline"
className="border-gray-700 text-white hover:bg-gray-800"
className="border-border text-foreground hover:bg-accent"
>
Cancel
</Button>
Expand Down
Loading