Handle Salesforce Bulk external IDs during transform#1
Conversation
# Description Replacing Uber's automaxprocs with go-kit's `maxprocs` package for VPA in-place support. ### Sidenotes I'm leaving `go.uber.org/automaxprocs` for the `regulation-worker`. ## Linear Ticket < No Linear Link > ## Security - [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.
…6444) # Description Switching to org-wide docker registry mirror configuration ## Security - [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| operation := determineOperation(normalizedExternalIDs, defaultOperation) | ||
| clonedMessage["rudderOperation"] = operation |
There was a problem hiding this comment.
The new transform helper computes operation := determineOperation(...) and unconditionally assigns it to clonedMessage["rudderOperation"]. This overwrites any rudderOperation already present in the incoming payload. Previously the transformer forwarded the payload as‑is, so callers could explicitly send rudderOperation: "delete" (or any other supported value) and have it respected. With this change, a message that already specifies a non‑default operation will now be forcibly changed—e.g., a delete request containing an externalId will be transformed into an upsert job, causing records to be inserted or updated instead of deleted. Unless the intention is to ignore all user‑provided operations, this introduces incorrect behavior for any event that explicitly sets rudderOperation.
Useful? React with 👍 / 👎.
etsenake
force-pushed
the
feat/salesforce-bulk-upload
branch
from
e3f4c49 to
0fed2ba
Compare
github-actions
Bot
deleted the
codex/implement-salesforce-async-job-helper
branch
3 participants
Summary
IdTesting
https://chatgpt.com/codex/tasks/task_e_68f2f4e0f3dc832a8954dfd809548b9e