Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SalesTerm XML errors raise verbose IntuitRequestException #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −11
Open

SalesTerm XML errors raise verbose IntuitRequestException #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2225e45
SalesTerm XML errors raise verbose IntuitRequestException
mcmire Oct 17, 2013
5e14bfb
Also rescue errors coming from Model.from_xml
mcmire Oct 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also rescue errors coming from Model.from_xml
@mcmire
mcmire committed Oct 17, 2013
commit 5e14bfb793d80c8e1bad016abb232952c114ad70
2 changes: 1 addition & 1 deletion lib/quickeebooks/online/service/sales_term.rb
View file
Original file line number Diff line number Diff line change
@@ -20,10 +20,10 @@ def fetch_object(model, url, params = {}, options = {})
xml = parse_xml(response.body)
begin
element = xml.at_xpath("//xmlns:#{model::XML_NODE}")
model.from_xml(element)
rescue Nokogiri::XML::XPath::SyntaxError => ex
raise IntuitRequestException.new("Error parsing XML: #{ex.message}\nHTTP Response: (#{response.code}) #{response.body}")
end
model.from_xml(element)
end
end
end