Skip to content

Revert "Cu 86dyxem56 hpe b2 b 3057 track users and sessions in experiment variants move to activities loader connor o brien" #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connortobrien wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Cu 86dyxem56 hpe b2 b 3057 track users and sessions in experiment variants move to activities loader connor o brien" #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 22 additions & 90 deletions init-activities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,26 +539,23 @@ function attachJsFile(src) {
rc.appendChild(sc);
}

// Module level - tracks variants loaded this page session
const loadedVariants = [];


function loadVariation(activity) {
const activityName = activity.activity;
const variations = activity.variants;
const storageValue = getJSONFromMemory(COOKIE_NAME) || { variations: {} };
const storageVariations = storageValue.variations || {};

// Check if variant already exists in cookie BEFORE any modifications
const existingVariant = storageVariations?.[activityName];
const hadValidVariant = existingVariant && variations?.[existingVariant];

// --- Helper: Weighted random selection ---
function selectVariation() {
// Calculate total weight first
let totalWeight = 0;
for (const key in variations) {
totalWeight += variations[key].weight;
}

// Generate random number in range [0, totalWeight)
let rand = Math.random() * totalWeight;
let sum = 0;

Expand All @@ -569,16 +566,19 @@ function loadVariation(activity) {
}
}

// Fallback: return the last key if somehow we get here
return Object.keys(variations)[Object.keys(variations).length - 1];
}

// --- Helper: Load JS file for variant ---
function loadVariantScript(activity, variantKey) {
const basePath = `${bucketPath}/${activity.group.toLowerCase()}/v2`;
const env = detectTypeOfEnvironment();
const filename = `fe_activity_${activity.activity}_${variantKey}${env === 'PROD' ? '.min' : ''}.js`;
attachJsFile(`${basePath}/${filename}`);
}

// --- Helper: Query Param FE_VARIANT parser ---
function getQueryParamVariantOverride() {
const match = window.location.href.match(/[?&]FE_VARIANT=([^&#]+)/);
if (!match) return null;
Expand All @@ -598,127 +598,61 @@ function loadVariation(activity) {
function setClarityTags(experiment, variant) {
try {
window.feUtils.waitForConditions({
conditions: [() => typeof window.clarity === 'function'],
conditions: [
() => typeof window.clarity === 'function',
],
activity: 'fe_altloader',
callback: () => {
window.clarity('set', 'experiment_id', experiment);
window.clarity('set', 'variant_id', variant);
},
});
} catch (err) {}
} catch(err) {}
}

function setTrackMetricsLink(experiment, variant) {
try {
window.feUtils.waitForConditions({
conditions: [() => typeof window.trackMetrics === 'function'],
conditions: [
() => typeof window.trackMetrics === 'function',
],
activity: 'fe_altloader',
callback: () => {
window.trackMetrics('new.link', { link_name: `mp:fe-experiment:fe-altloader:${experiment}:${variant}` });
},
});
} catch (err) {}
} catch(err) {}
}

// --- 1. Handle FE_VARIANT override (no tracking) ---
// --- 1. Handle FE_VARIANT override ---
const variantOverride = getQueryParamVariantOverride();
const overrideVariant = variantOverride?.[activityName];

if (overrideVariant && variations?.[overrideVariant]) {
// set storage to value used in override
storageVariations[activityName] = overrideVariant;
setJSONToMemory(COOKIE_NAME, { ...storageValue, variations: storageVariations });
setClarityTags(activityName, overrideVariant);
setTrackMetricsLink(activityName, overrideVariant);
loadVariantScript(activity, overrideVariant);
// No tracking for overrides
// Load overridden variant without modifying storage
loadVariantScript(activity, overrideVariant, env);
return;
}

// --- 2. Normal flow ---
let selectedVariation;
// --- 2. Normal flow using storage or selection ---
let selectedVariation = storageVariations?.[activityName];

if (hadValidVariant) {
selectedVariation = existingVariant;
} else {
selectedVariation = selectVariation();
if (!selectedVariation || !variations?.[selectedVariation]) {
selectedVariation = selectVariation(variations);
storageVariations[activityName] = selectedVariation;
setJSONToMemory(COOKIE_NAME, { ...storageValue, variations: storageVariations });
}

// Track this load (only for trackable activities starting with '3')
if (activityName.startsWith('3')) {
loadedVariants.push({
activity: activityName,
variant: selectedVariation,
isNew: !hadValidVariant,
});
}

setClarityTags(activityName, selectedVariation);
setTrackMetricsLink(activityName, selectedVariation);
loadVariantScript(activity, selectedVariation);
}

// Call this after all activities have been processed
function sendVariantLoadTracking() {
if (loadedVariants.length === 0) return;

// Deduplicate: prevent multiple API calls if script loads twice
const TRACKING_KEY = 'fe_tracking_sent';
const pageLoadId = `${window.location.href}_${performance.timeOrigin}`;

if (sessionStorage.getItem(TRACKING_KEY) === pageLoadId) {
return; // Already sent for this page load
}
sessionStorage.setItem(TRACKING_KEY, pageLoadId);

const cookie = getJSONFromMemory(COOKIE_NAME) ?? {};
const env = detectTypeOfEnvironment();

// Determine if this is a conversion page

fetch('https://funnelenvy.retool.com/url/track-hits', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
cookie,
env,
variants: loadedVariants,
}),
});
}

function sendConversionTracking() {
const pathname = window.location.pathname ?? '';
let conversion_type = '';
let internal_id = '';
let env = window.FeActivityLoader.detectTypeOfEnvironment();
const cookie = getJSONFromStorage(COOKIE_NAME) ?? {};
if (pathname.includes('/quoteConfirmSummary')) {
internal_id = pathname.match(/\/quote\/([^\/]+)\/quoteConfirmSummary$/)?.[1] ?? '';
conversion_type = 'quote';
} else if (pathname.includes('/orderConfirmation')) {
internal_id = pathname.match(/\/checkout\/orderConfirmation\/([^\/]+)$/)?.[1] ?? '';
conversion_type = 'order';
}
if (conversion_type === '') return;
const activities = Object.keys(cookie?.variations ?? {});
if (activities.filter(a => a.startsWith('3')).length > 0) {
fetch('https://funnelenvy.retool.com/url/track-conversion', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
},
body: JSON.stringify({
internal_id,
conversion_type,
cookie,
env,
}),
});
}
}

window.FeActivityLoader = window.FeActivityLoader || {};
window.FeActivityLoader.getActivities = getActivities;
window.FeActivityLoader.getAudiences = getAudiences;
Expand Down Expand Up @@ -795,8 +729,6 @@ const loadActivities = () => {
});
}

sendConversionTracking();
sendVariantLoadTracking();
// Clean up any stored variations for activities that no longer exist or are disabled
cleanupStoredVariations();
}
Expand Down