Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Adds Link text to go to IAP homepage on Browse IT jobs page #4586

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Bug - Adds Link text to go to IAP homepage on Browse IT jobs page #4586

merged 3 commits into from
Nov 7, 2022

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Nov 3, 2022

Resolves #4558.

Steps to test

  1. Compile talentsearch npm run intl-compile --workspace=talentsearch
  2. Build talentsearch npm run production --workspace=talentsearch
  3. Navigate to /en/browse/pools
  4. Confirm there is a button with the text Apply now
  5. Navigate to /en/browse/pools
  6. Confirm there is a button with the text Inscrivez-vous maintenant

petertgiles
petertgiles requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better string! Looks like it needs a little tweak though.

frontend/talentsearch/src/js/components/Browse/BrowsePoolsPage.tsx Show resolved Hide resolved
@mnigh mnigh merged commit 9968de2 into main Nov 7, 2022
@mnigh mnigh deleted the bug/4558-i18n branch November 7, 2022 16:19
@esizer esizer mentioned this pull request Nov 22, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esizer esizer esizer left review comments

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Link text to go to IAP homepage on browse IT jobs page
3 participants
@mnigh @esizer @petertgiles